Review Request 125053: Fix crash if trying to load an invalid applet in systray

Kai Uwe Broulik kde at privat.broulik.de
Sat Sep 5 08:11:58 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125053/#review84860
-----------------------------------------------------------

Ship it!


Perhaps print a warning


applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp (line 55)
<https://git.reviewboard.kde.org/r/125053/#comment58706>

    braces please


- Kai Uwe Broulik


On Sept. 4, 2015, 11:09 nachm., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125053/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2015, 11:09 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> BUG: 352294
> REVIEW:
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/plugin/protocols/plasmoid/plasmoidtask.cpp 1528c7adbdafebec53c0650853ed17b0e961e1bf 
> 
> Diff: https://git.reviewboard.kde.org/r/125053/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150905/1da845cd/attachment-0001.html>


More information about the Plasma-devel mailing list