Review Request 125050: Fixed wrong path in cursor theme KCM
David Edmundson
david at davidedmundson.co.uk
Fri Sep 4 18:44:58 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125050/#review84845
-----------------------------------------------------------
patch looks good, but why are you in the else branch of
if(X11_Xcursor_FOUND)
?
You want to fix that on the packaging side rather than having this patch
- David Edmundson
On Sept. 4, 2015, 6:42 p.m., Ovidiu-Florin BOGDAN wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125050/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2015, 6:42 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: plasma-desktop
>
>
> Description
> -------
>
> Path was wrong. Could not compile.
>
>
> Diffs
> -----
>
> kcms/cursortheme/CMakeLists.txt e7613c0
>
> Diff: https://git.reviewboard.kde.org/r/125050/diff/
>
>
> Testing
> -------
>
> It compiled.
>
>
> Thanks,
>
> Ovidiu-Florin BOGDAN
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150904/01719c50/attachment.html>
More information about the Plasma-devel
mailing list