Review Request 125040: Disable gui if the webkitwidgets module is not found

Martin Gräßlin mgraesslin at kde.org
Fri Sep 4 13:56:52 UTC 2015



> On Sept. 4, 2015, 8:03 a.m., Martin Gräßlin wrote:
> > I'm missing an
> > add_subdirectory(Darwin)
> > 
> > otherwise I think the new CMakeLists would ever be found.
> 
> Samuel Gaist wrote:
>     It's already automatically handled by `add_subdirectory( ${CMAKE_SYSTEM_NAME} )` 
>     
>     It's located just under the "SunOS" if

ah nice, didn't notice that. Thanks for clarification.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125040/#review84806
-----------------------------------------------------------


On Sept. 4, 2015, 12:05 a.m., Samuel Gaist wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125040/
> -----------------------------------------------------------
> 
> (Updated Sept. 4, 2015, 12:05 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: ksysguard
> 
> 
> Description
> -------
> 
> This follows the behavior of libksysguard
> 
> Add dummy support for Darwin
> 
> This patch reuses the GNU dummy implementation to allow build on OS X
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b6b12d9d2e15942f986a0a2826bad5c7fbe92a8e 
>   ksysguardd/Darwin/CMakeLists.txt PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125040/diff/
> 
> 
> Testing
> -------
> 
> Build on OS X 10.8
> 
> 
> Thanks,
> 
> Samuel Gaist
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150904/464467ec/attachment.html>


More information about the Plasma-devel mailing list