Review Request 125028: Monitor for the clock changes from the kernel

[David Edmundson]

> On Sept. 3, 2015, 3:39 p.m., Martin Klapetek wrote:
> > Have you tested this? Does the notification work with the zero timer?

yes. I ran sudo timedatectl set-time 22:53 and watched the clock change and the debug appear.


> On Sept. 3, 2015, 3:39 p.m., Martin Klapetek wrote:
> > dataengines/time/timeengine.cpp, line 71
> > <https://git.reviewboard.kde.org/r/125028/diff/2/?file=400136#file400136line71>
> >
> >     Should this maybe also set TFD_NONBLOCK? To avoid blocking calls?

/Shouldn't/ be needed as I'm not doing a read unless I get the socket activated, but won't do any harm. Will add.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125028/#review84792
-----------------------------------------------------------


On Sept. 3, 2015, 9:36 a.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125028/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2015, 9:36 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> At the moment we update the clock when we resume from suspend or from
> the time KCM.
> 
> However the signal from the clock KCM isn't very good as it signals just
> after it requests an NTP update or clock change, not necessarily when
> that finishes.
> 
> Also we miss any external NTP updates which might occur at other times
> throughout the day, such as a big change when we connect to the network
> 
> This method also avoids needing solid to tell us when we're resuming
> from suspend, which is deprecated API and also seems slightly slower.
> 
> BUG: 344870
> 
> 
> Diffs
> -----
> 
>   dataengines/time/timeengine.cpp 2fd9792209ff5e78bd3dee1ed938eb0b1173de8d 
> 
> Diff: https://git.reviewboard.kde.org/r/125028/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150903/e296f2d4/attachment.html>