Review Request 125030: kwayland contrast protocol

[Marco Martin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125030/
-----------------------------------------------------------

(Updated Sept. 3, 2015, 1:58 p.m.)


Review request for kwin and Plasma.


Repository: kwayland


Description
-------

new wayland protocol used to define regions behind a window 
in which the kwin background contrast effect should be applied


Diffs (updated)
-----

  autotests/client/CMakeLists.txt acc1cc0 
  autotests/client/test_wayland_contrast.cpp PRE-CREATION 
  autotests/client/test_wayland_registry.cpp 9cef0d4 
  src/client/CMakeLists.txt e269997 
  src/client/contrast.h PRE-CREATION 
  src/client/contrast.cpp PRE-CREATION 
  src/client/protocols/contrast.xml PRE-CREATION 
  src/client/registry.h 2a31ab4 
  src/client/registry.cpp e890c69 
  src/server/CMakeLists.txt 9d99325 
  src/server/display.h cd43b03 
  src/server/display.cpp 75adc14 
  src/server/surface_interface.h f8f9be7 
  src/server/surface_interface.cpp 0f62d13 
  src/server/surface_interface_p.h 2b55f81 

Diff: https://git.reviewboard.kde.org/r/125030/diff/


Testing
-------

fail in autotests: fun converting between double and "fixed"
Actual   (serverSurface->contrast()->contrast()): 0.199219
Expected (0.2)                                  : 0.2


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150903/4e54bced/attachment.html>