Review Request 125012: [kicker] add key navigation wrap to dashboard filterList

David Edmundson david at davidedmundson.co.uk
Thu Sep 3 10:05:10 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125012/#review84783
-----------------------------------------------------------


do you have commit access?

- David Edmundson


On Sept. 3, 2015, 1:22 a.m., Takahiro Hashimoto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125012/
> -----------------------------------------------------------
> 
> (Updated Sept. 3, 2015, 1:22 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Now new Kicker dashboard's filterList isn't wraped by up/down key navigation. 
> This simple patch make it enabled by setting 'keyNavigationWraps' property of ListView.
> 
> 
> Diffs
> -----
> 
>   applets/kicker/package/contents/ui/DashboardRepresentation.qml eeb4837 
> 
> Diff: https://git.reviewboard.kde.org/r/125012/diff/
> 
> 
> Testing
> -------
> 
> Press up key on the top of filterList menu. : highlight moved to bottom.
> Press down key on the bottom of filterList menu: highlight moved to top.
> 
> 
> Thanks,
> 
> Takahiro Hashimoto
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150903/ecf5da19/attachment.html>


More information about the Plasma-devel mailing list