Review Request 124877: fix corruption of startupconfig(files) in Qt5.6

[Takahiro Hashimoto]

> On 9月 2, 2015, 11:14 p.m., Alex Richardson wrote:
> > startkde/kstartupconfig/kdostartupconfig.cpp, line 86
> > <https://git.reviewboard.kde.org/r/124877/diff/1/?file=397209#file397209line86>
> >
> >     `QByteArray buf = keys.readLine()`
> >     
> >     I don't see the point of preallocation 1024 bytes (I doubt this does any good anyway) and using the less safe C-style API
> 
> Alex Richardson wrote:
>     Or even better just `QString line = QString::fromLocal8Bit(keys.readLine());`

Yay I agree with you. I'd like to update patch.


- Takahiro


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124877/#review84764
-----------------------------------------------------------


On 9月 3, 2015, 12:18 a.m., Takahiro Hashimoto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124877/
> -----------------------------------------------------------
> 
> (Updated 9月 3, 2015, 12:18 a.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 351609
>     https://bugs.kde.org/show_bug.cgi?id=351609
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Building Plasma5 with Qt 5.6 branch, kstartupconfig5/kdostartupconfig5 generates corrupted files.
> 
> $HOME/.config/startupconfigfiles
> $HOME/.config/startupconfig
> 
> 
> Diffs
> -----
> 
>   startkde/kstartupconfig/kdostartupconfig.cpp 3944c06 
> 
> Diff: https://git.reviewboard.kde.org/r/124877/diff/
> 
> 
> Testing
> -------
> 
> works for me. 
> 
> 1. execute kstartupconfig5
> 2. check if both files are not corrupted.
> 
> 
> Thanks,
> 
> Takahiro Hashimoto
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150902/36f1db76/attachment-0001.html>