Review Request 121915: Add lidClosedChanged signal to org.kde.Solid.PowerManagement

Daniel Vrátil dvratil at kde.org
Wed Sep 2 11:38:35 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121915/
-----------------------------------------------------------

(Updated Sept. 2, 2015, 11:38 a.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma and Solid.


Changes
-------

Submitted with commit b5a1e1bec3052460ff8c87764a065cc61cdeba47 by Dan Vrátil to branch master.


Repository: powerdevil


Description
-------

There's no way to detect when lid has been closed other than listening to `changed` signal org.freedesktop.UPower and then polling the Powerdevil for new values. This patch adds a new signal to the PowerDevil interface to notify about the change and provide new value right away. Makes it much easier to use.


Diffs
-----

  daemon/org.kde.Solid.PowerManagement.xml 53f77e5 
  daemon/powerdevilbackendinterface.h 702b66b 
  daemon/powerdevilbackendinterface.cpp 6dd8c71 
  daemon/powerdevilcore.h e255703 
  daemon/powerdevilcore.cpp d51ab19 

Diff: https://git.reviewboard.kde.org/r/121915/diff/


Testing
-------

Tested with qdbus-monitor, signal is emitted when laptop lid is closed/opened.


Thanks,

Daniel Vrátil

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150902/7394cb87/attachment.html>


More information about the Plasma-devel mailing list