Review Request 125028: Monitor for the clock changes from the kernel

David Edmundson david at davidedmundson.co.uk
Wed Sep 2 10:29:30 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125028/
-----------------------------------------------------------

Review request for Plasma.


Repository: plasma-workspace


Description
-------

At the moment we update the clock when we resume from suspend or from
the time KCM.

However the signal from the clock KCM isn't very good as it signals just
after it requests an NTP update or clock change, not necessarily when
that finishes.

Also we miss any external NTP updates which might occur at other times
throughout the day, such as a big change when we connect to the network

This method also avoids needing solid to tell us when we're resuming
from suspend, which is deprecated API and also seems slightly slower.

BUG: 344870


Diffs
-----

  dataengines/time/timeengine.cpp 2fd9792209ff5e78bd3dee1ed938eb0b1173de8d 

Diff: https://git.reviewboard.kde.org/r/125028/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150902/d4c8303a/attachment.html>


More information about the Plasma-devel mailing list