Review Request 124374: custom inline edit menu for plasma controls

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124374/#review84743
-----------------------------------------------------------


+1

A few style nitpicks I didn't explicitly mention below (spaces at /2 and stuff)


src/declarativeimports/plasmastyle/CursorDelegate.qml (line 2)
<https://git.reviewboard.kde.org/r/124374/#comment58642>

    ;)



src/declarativeimports/plasmastyle/CursorDelegate.qml (line 64)
<https://git.reviewboard.kde.org/r/124374/#comment58643>

    Remove



src/declarativeimports/plasmastyle/EditMenuTouch.qml (line 53)
<https://git.reviewboard.kde.org/r/124374/#comment58644>

    Why do you change the Z? it becomes invisible anyway



src/declarativeimports/plasmastyle/EditMenuTouch.qml (line 62)
<https://git.reviewboard.kde.org/r/124374/#comment58645>

    Imho it's cleaner if we just have a floating paste button if you cannot copy/paste but that's up to the designers I guess, though a word will always be selected when we bring up the menu? There's no "tap, wait, paste" feature?



src/declarativeimports/plasmastyle/EditMenuTouch.qml (line 64)
<https://git.reviewboard.kde.org/r/124374/#comment58646>

    control.cut() and co? makes it more explicit


- Kai Uwe Broulik


On Sept. 1, 2015, 12:14 nachm., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124374/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2015, 12:14 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-framework
> 
> 
> Description
> -------
> 
> This depends from https://codereview.qt-project.org/#/c/121659/
> provides the needed elements for touch based text selection and inline (no separate window) menu for cut/copy/paste
> 
> 
> Diffs
> -----
> 
>   src/declarativeimports/plasmastyle/CursorDelegate.qml PRE-CREATION 
>   src/declarativeimports/plasmastyle/CursorHandleStyle.qml PRE-CREATION 
>   src/declarativeimports/plasmastyle/EditMenuTouch.qml PRE-CREATION 
>   src/declarativeimports/plasmastyle/SelectionHandleStyle.qml PRE-CREATION 
>   src/declarativeimports/plasmastyle/TextAreaStyle.qml 114c322 
>   src/declarativeimports/plasmastyle/TextFieldStyle.qml 635c938 
> 
> Diff: https://git.reviewboard.kde.org/r/124374/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> snapshot1.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/07/16/7fb4e7da-e705-4bd1-b084-1a69145a0bc2__snapshot1.png
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150902/3a6ab34e/attachment.html>