Review Request 125016: stub effects implementation + blur implementation

[Martin Gräßlin]

> On Sept. 1, 2015, 2:31 p.m., Martin Gräßlin wrote:
> > src/windowsystem/windoweffects.cpp, lines 61-71
> > <https://git.reviewboard.kde.org/r/125016/diff/1/?file=399902#file399902line61>
> >
> >     use Qt::QueuedConnections. QtWayland has the connection in a different thread. As we know that I think we should make it explicit that this passes thread boundaries.
> 
> Marco Martin wrote:
>     problem is if i do then this function will return before blurAnnounced, and m_blurSupported will be false for the first few times isEffectAvailable is called. without queued connection i *seems * to work

hmm, interesting: it should be also QueuedConnection currently as it passes thread boundaries the default should be queued. Maybe we are missing the event queue. I'll play with it once it's in.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125016/#review84699
-----------------------------------------------------------


On Sept. 1, 2015, 2 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125016/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2015, 2 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwayland-integration
> 
> 
> Description
> -------
> 
> implements an empty effects plugin for kwindowsystem, only blur has a full implementation so far
> 
> 
> Diffs
> -----
> 
>   src/windowsystem/CMakeLists.txt 334ba4f 
>   src/windowsystem/plugin.h c131a85 
>   src/windowsystem/plugin.cpp 44f5d95 
>   src/windowsystem/windoweffects.h PRE-CREATION 
>   src/windowsystem/windoweffects.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125016/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150901/28edd770/attachment-0001.html>