Review Request 125016: stub effects implementation + blur implementation

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125016/#review84699
-----------------------------------------------------------



src/windowsystem/windoweffects.cpp (lines 37 - 40)
<https://git.reviewboard.kde.org/r/125016/#comment58621>

    nullptr or Q_NULLPTR instead of 0



src/windowsystem/windoweffects.cpp (lines 51 - 53)
<https://git.reviewboard.kde.org/r/125016/#comment58616>

    I don't think we need that check as the plugin won't be loaded on other platforms?



src/windowsystem/windoweffects.cpp (lines 61 - 71)
<https://git.reviewboard.kde.org/r/125016/#comment58618>

    use Qt::QueuedConnections. QtWayland has the connection in a different thread. As we know that I think we should make it explicit that this passes thread boundaries.



src/windowsystem/windoweffects.cpp (line 68)
<https://git.reviewboard.kde.org/r/125016/#comment58619>

    please connect to the removed signal and:
    * set m_blurSupported to false
    * deleteLater the m_waylandBlurManager



src/windowsystem/windoweffects.cpp (line 91)
<https://git.reviewboard.kde.org/r/125016/#comment58620>

    nitpick: whitespace and Q_UNUSED


- Martin Gräßlin


On Sept. 1, 2015, 2 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125016/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2015, 2 p.m.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwayland-integration
> 
> 
> Description
> -------
> 
> implements an empty effects plugin for kwindowsystem, only blur has a full implementation so far
> 
> 
> Diffs
> -----
> 
>   src/windowsystem/CMakeLists.txt 334ba4f 
>   src/windowsystem/plugin.h c131a85 
>   src/windowsystem/plugin.cpp 44f5d95 
>   src/windowsystem/windoweffects.h PRE-CREATION 
>   src/windowsystem/windoweffects.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125016/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20150901/eecea535/attachment-0001.html>