Review Request 125897: [Clipboard plasmoid] Fix line breaks

[Thomas Pfeiffer]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125897/#review87786
-----------------------------------------------------------


Showing the whitespaces only for the first line does not make much sense to me, as that would bring back the original problem fixed by the highlighting (that what gets pasted in is not the same as what you saw in the preview).
Therefore it should show the whitespaces for all lines.

- Thomas Pfeiffer


On Oct. 31, 2015, 4:47 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125897/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2015, 4:47 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This fixes the list only showing one line of text instead of the supposed maximum of 3 lines.
> 
> I'm unsure about the "m" modifier, however. With it, it highlights leading and trailing whitespace on any line which can be nice but also somewhat distracting depending on what you copied. On the other hand, only doing it for the first line (as is now but wasnt apparent because we only showed one line) is also strange. Especially when you use spaces rather than line breaks you can get quite a few "space" indicators.. (I can split the patch though, broken multiline display is definitely a bug)
> 
> 
> Diffs
> -----
> 
>   applets/clipboard/contents/ui/ClipboardItemDelegate.qml b263656 
> 
> Diff: https://git.reviewboard.kde.org/r/125897/diff/
> 
> 
> Testing
> -------
> 
> Works
> 
> 
> File Attachments
> ----------------
> 
> With multiline modifier
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/10/31/24d3504f-856d-4548-b01a-4cf86b2cd348__klipperlinebreaks2.png
> Without (currently)
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/10/31/d052169b-0026-4efa-b781-68b39cc20bf0__klipperlinebreaks1.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151031/2598d3f3/attachment.html>