Review Request 125886: drkonqi: Drop KF5::WebKit dependency
David Rosca
nowrep at gmail.com
Sat Oct 31 10:54:29 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125886/
-----------------------------------------------------------
Review request for Plasma.
Repository: plasma-workspace
Description
-------
Replace KWebView with QTextBrowser in unhandled bugzilla error dialog.
KWebView is not used to load a page here, it is just used to display HTML with setHtml (without baseUrl) so any external URLs (stylesheets, images, ...) are not resolved.
Replacing it with QTextBrowser should provide similar rendering.
Diffs
-----
CMakeLists.txt 50091ea
drkonqi/CMakeLists.txt 339b475
drkonqi/bugzillaintegration/reportassistantpages_bugzilla.cpp b6beea3
Diff: https://git.reviewboard.kde.org/r/125886/diff/
Testing
-------
Made sure it builds, no idea how to trigger the dialog.
Thanks,
David Rosca
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151031/673df3a0/attachment.html>
More information about the Plasma-devel
mailing list