Review Request 125878: fix lost QuickViewSharedEngine initialSize on initializing

[Takahiro Hashimoto]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125878/
-----------------------------------------------------------

(Updated Oct. 30, 2015, 9:06 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, David Edmundson and David Faure.


Changes
-------

Submitted with commit 4ca3237c2e07ac035104af5730bd209c18f61fe2 by Takahiro Hashimoto to branch master.


Repository: kdeclarative


Description
-------

After my commit 1c3f42afe17cc090372eaf45647d71495de12c19, view's initialiSize value is lost (remaining 0,0 in spite of item's size). It should be set by item's size for some reusing purpose (with initialSize() getter) 

Sorry again my bad commit :(


Diffs
-----

  src/quickaddons/quickviewsharedengine.cpp 323cf92 

Diff: https://git.reviewboard.kde.org/r/125878/diff/


Testing
-------

build and run test

kenya888 at xps13 ~/devel/kf5/build/frameworks/kdeclarative $ ninja test
[1/1] Running tests...
Test project /home/kenya888/devel/kf5/build/frameworks/kdeclarative
    Start 1: fullmodelaccesstest
1/2 Test #1: fullmodelaccesstest ..............   Passed    0.05 sec
    Start 2: quickviewsharedengine
2/2 Test #2: quickviewsharedengine ............   Passed    0.39 sec

100% tests passed, 0 tests failed out of 2

Total Test time (real) =   0.44 sec

------

confirmed ksplashqml works well which use QuickViewSharedEngine.


Thanks,

Takahiro Hashimoto

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151030/beae12c6/attachment.html>