Review Request 125864: Add back the Agenda part of the Calendar

Martin Klapetek martin.klapetek at gmail.com
Fri Oct 30 19:11:00 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125864/
-----------------------------------------------------------

(Updated Oct. 30, 2015, 8:11 p.m.)


Review request for Plasma.


Changes
-------

+ fix issues
+ add time label to the events, see new screenshot

I'm not entirely sure about the offset of the label when there is just one time (the todo in the screenshot)
but it makes all things with time aligned properly, so I dunno. Thoughts?


Repository: plasma-workspace


Description
-------

Adds back the Agenda that was there pre-5.0 with some changes.

It now shows an overview of the given day events/holidays. I'd
like to add a second view at some point that would show you the
selected day by hours but that is much more work and the freeze
is getting closer, so maybe that will have to wait till 5.6.


Diffs (updated)
-----

  applets/digital-clock/package/contents/ui/CalendarView.qml b52eb10 

Diff: https://git.reviewboard.kde.org/r/125864/diff/


Testing
-------

Selecting a day correctly changes the date in the agenda and correctly displays the events of the day.

Event removal/modification also removes/modifies it from the agenda.


File Attachments (updated)
----------------

Current look in Breeze
  https://git.reviewboard.kde.org/media/uploaded/files/2015/10/29/5485250c-8d20-409e-8a5b-0eda7a9d7b8d__snapshot29.png
Multiple same-day events
  https://git.reviewboard.kde.org/media/uploaded/files/2015/10/29/d453a01e-f9cf-4da3-8f6a-fac5aa6aadf5__snapshot18.png
New screenshot
  https://git.reviewboard.kde.org/media/uploaded/files/2015/10/30/c75fed5e-02fd-4906-8bd9-726f0fc54ce8__snapshot30.png


Thanks,

Martin Klapetek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151030/854689ed/attachment-0001.html>


More information about the Plasma-devel mailing list