Review Request 125871: WIP: task geometries to wayland for minimize effect

Marco Martin notmart at gmail.com
Fri Oct 30 17:37:52 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125871/
-----------------------------------------------------------

(Updated Oct. 30, 2015, 5:37 p.m.)


Review request for kwin and Plasma.


Repository: kwayland


Description
-------

this exposes the geometry of taskbar entries in plasma-windowmanagement, in order to make the minimize effects possible.
unlike on X11, it takes relative positions and it has one geometry per panel, making possible to have multiple taskbars working.

however this is still not completely exposed, as internally kwin has still only one geometry, it will need a change in kwin itself (suggestions welcome) probably the rotocol will need also a minimizeTo function that takes the panel as argument.

another thing completely missing is tests: unfortunately the whole plasma-windowmanagement doesn't have any autotest yet :/


Diffs (updated)
-----

  autotests/client/CMakeLists.txt 1556c47 
  autotests/client/test_wayland_shell.cpp 94cc03d 
  autotests/client/test_wayland_windowmanagement.cpp PRE-CREATION 
  src/client/plasmawindowmanagement.h abd8fa6 
  src/client/plasmawindowmanagement.cpp 1f9674c 
  src/client/plasmawindowmodel.h 5a6aac4 
  src/client/plasmawindowmodel.cpp 355ef53 
  src/client/protocols/plasma-window-management.xml ca6a7cc 
  src/client/shell.h b545c07 
  src/client/shell.cpp f4b0ca5 
  src/server/plasmashell_interface.h 9db3f52 
  src/server/plasmashell_interface.cpp d29d7bc 
  src/server/plasmawindowmanagement_interface.h 6ccc22e 
  src/server/plasmawindowmanagement_interface.cpp ad714a5 
  src/server/seat_interface.h d4f23be 
  src/server/shell_interface.h e0c5bd2 
  src/server/shell_interface.cpp 69e22e6 

Diff: https://git.reviewboard.kde.org/r/125871/diff/


Testing
-------


Thanks,

Marco Martin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151030/dc30ca0a/attachment.html>


More information about the Plasma-devel mailing list