Review Request 125873: preliminar support for task geometries in wayland

[Thomas Lübking]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125873/#review87753
-----------------------------------------------------------



abstract_client.h (line 601)
<https://git.reviewboard.kde.org/r/125873/#comment60206>

    cough, kate/kwrite/kdevelop btw. has this fancy feature to autofix that for you (and so does vim ;-)



shell_client.cpp (line 402)
<https://git.reviewboard.kde.org/r/125873/#comment60208>

    hint, start with INT_MAX.
    Spares you a logic-error prone bug ;-)



shell_client.cpp (line 408)
<https://git.reviewboard.kde.org/r/125873/#comment60211>

    can we please go for
    
    for (auto i = windowManagementInterface()->taskGeometries().constBegin(), end = windowManagementInterface()->taskGeometries().constEnd(); i != end; ++i)
    
    instead of while loops (with random increment position)?



shell_client.cpp (line 409)
<https://git.reviewboard.kde.org/r/125873/#comment60212>

    local variable, "const int distance = ..." - this ain't C-99 ;-)



shell_client.cpp (line 410)
<https://git.reviewboard.kde.org/r/125873/#comment60207>

    take a close look at this line, then fix it :-)



shell_client.cpp (line 412)
<https://git.reviewboard.kde.org/r/125873/#comment60209>

    should the panel also be tested for being on the same screen (ie. same screen takes precedence over closer, but other screen)?



shell_client.cpp (line 413)
<https://git.reviewboard.kde.org/r/125873/#comment60210>

    just store the iterator?


- Thomas Lübking


On Okt. 30, 2015, 4:08 nachm., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125873/
> -----------------------------------------------------------
> 
> (Updated Okt. 30, 2015, 4:08 nachm.)
> 
> 
> Review request for kwin and Plasma.
> 
> 
> Repository: kwin
> 
> 
> Description
> -------
> 
> make the minimize effect work by reading taskGeometry from plasmawindowmanagement and returning as iconGeometry().
> 
> It still supports a single taskbar as on x11. the architecture will have to change somehow to allow to know from where panel we want to minimize (or if not secified searching for the nearest panel)
> suggestions welcome :)
> 
> 
> Diffs
> -----
> 
>   abstract_client.h 128c141 
>   client.h f22e690 
>   shell_client.h fee22c4 
>   shell_client.cpp 79a1ac5 
> 
> Diff: https://git.reviewboard.kde.org/r/125873/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151030/2f9d4fc6/attachment.html>