Review Request 125862: Add simple calendar events plugin based on KHolidays

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125862/#review87715
-----------------------------------------------------------



CMakeLists.txt (line 31)
<https://git.reviewboard.kde.org/r/125862/#comment60178>

    Should it be a required dep? I think it wasn't in 4.x? And reading the code it should be easy to have it optional as we just need to make the one add_subdirectory call conditional.



plasmacalendarintegration/holidaysevents.h (line 42)
<https://git.reviewboard.kde.org/r/125862/#comment60179>

    suggestion: QScopedPointer to not having to manually delete it


- Martin Gräßlin


On Oct. 29, 2015, 5:01 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125862/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2015, 5:01 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> This is very simple for now as there is no configuration
> yet, so it just takes the default region (your locale)
> and shows holidays from that.
> 
> Obviously this needs a config to set up which regions
> you want to show in there, but this is a start.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 50091ea 
>   plasmacalendarintegration/CMakeLists.txt PRE-CREATION 
>   plasmacalendarintegration/holidaysevents.h PRE-CREATION 
>   plasmacalendarintegration/holidaysevents.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125862/diff/
> 
> 
> Testing
> -------
> 
> Holidays are properly listed in calendar applet.
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151030/271eb25b/attachment.html>