Review Request 125870: Update drkonqui hints for relevant information

David Edmundson david at davidedmundson.co.uk
Thu Oct 29 17:45:54 UTC 2015



> On Oct. 29, 2015, 5:22 p.m., Kai Uwe Broulik wrote:
> > drkonqi/applicationdetailsexamples.cpp, line 36
> > <https://git.reviewboard.kde.org/r/125870/diff/1/?file=413314#file413314line36>
> >
> >     you forgot parenthesis after "kwin_x11"

Thanks, I was obviously deliberately testing who'd notice it in a review obviously. You passed.

Fixed both.


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125870/#review87686
-----------------------------------------------------------


On Oct. 29, 2015, 5:12 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125870/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2015, 5:12 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Update drkonqui hints for relevant information
> 
> 
> Diffs
> -----
> 
>   drkonqi/applicationdetailsexamples.cpp 65ceb18cf2bd9eccf666e5c95273513857f660d3 
> 
> Diff: https://git.reviewboard.kde.org/r/125870/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151029/91ea1214/attachment.html>


More information about the Plasma-devel mailing list