Review Request 125858: Fix SystemLoadViewer freezing plasmashell

[Kåre Särs]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125858/
-----------------------------------------------------------

(Updated Oct. 29, 2015, 12:18 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, David Edmundson and Martin Yrjölä.


Changes
-------

Submitted with commit 351c2a03827040d148a1b73dbeab12eb3d3e69de by Kåre Särs to branch master.


Repository: kdeplasma-addons


Description
-------

The SystemLoadViewer freezes plasmashell when the systemmonitor data-engine returns erroneous values. The freeze only happens with the compact bars selected.

This patch ensures that the proportions of the loads do not exceed 1.

This patch should fix BUG: 348385


Diffs
-----

  applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 8023b44 

Diff: https://git.reviewboard.kde.org/r/125858/diff/


Testing
-------

I did run a version of this patch over night that had extra debug printouts and I got 17 printouts with huge values returned. The limitation of the value to max 1, prevented freezes.


Thanks,

Kåre Särs

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151029/12fd93a1/attachment.html>