Review Request 125858: Fix SystemLoadViewer freezing plasmashell

[Kåre Särs]

> On Oct. 29, 2015, 9:33 a.m., Marco Martin wrote:
> > ok with the patch, but the dataengine should be fixed as well?

Yes somebody should fix it, but I'm not familiar with the data engine... and in the bug report David Edmundson said: "for 5.5 I'm rewriting this garbage with a proper import where we have types done properly." ;)


- Kåre


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125858/#review87653
-----------------------------------------------------------


On Oct. 29, 2015, 7:20 a.m., Kåre Särs wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125858/
> -----------------------------------------------------------
> 
> (Updated Oct. 29, 2015, 7:20 a.m.)
> 
> 
> Review request for Plasma, David Edmundson and Martin Yrjölä.
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> The SystemLoadViewer freezes plasmashell when the systemmonitor data-engine returns erroneous values. The freeze only happens with the compact bars selected.
> 
> This patch ensures that the proportions of the loads do not exceed 1.
> 
> This patch should fix BUG: 348385
> 
> 
> Diffs
> -----
> 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 8023b44 
> 
> Diff: https://git.reviewboard.kde.org/r/125858/diff/
> 
> 
> Testing
> -------
> 
> I did run a version of this patch over night that had extra debug printouts and I got 17 printouts with huge values returned. The limitation of the value to max 1, prevented freezes.
> 
> 
> Thanks,
> 
> Kåre Särs
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151029/a06b1cf1/attachment.html>