Review Request 125848: [kscreenlocker_greet] Fix QML fallback

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125848/#review87649
-----------------------------------------------------------

Ship it!


Ship It!

- Martin Gräßlin


On Oct. 28, 2015, 9:46 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125848/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2015, 9:46 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> With the change to the QQuickSharedEngine, it seems to load synchronously, meaning the status changed slot is never called and when I broke my lockscreen I locked myself out in the process.
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/greeter/greeterapp.h becd669 
>   ksmserver/screenlocker/greeter/greeterapp.cpp a88b61a 
> 
> Diff: https://git.reviewboard.kde.org/r/125848/diff/
> 
> 
> Testing
> -------
> 
> Broke my lock screen. Got the fallback.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151029/df466ad0/attachment.html>