Review Request 125845: Use KDE_INSTALL_DBUSINTERFACEDIR to install dbus interfaces
Alex Merry
alex.merry at kde.org
Wed Oct 28 20:19:22 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125845/#review87616
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Merry
On Oct. 28, 2015, 5:44 p.m., Heiko Becker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125845/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2015, 5:44 p.m.)
>
>
> Review request for Plasma.
>
>
> Repository: khotkeys
>
>
> Description
> -------
>
> ...and use PATH_VARS to make the config file work with absolute paths.
>
> Two reasons to do this:
> - DBUS_INTERFACES_INSTALL_DIR is marked deprecated
> - Not hard-coding the packackage prefix is helpful on a multiarch
> layout where the prefix is /usr/${host} but arch-independent files
> should still be installed to /usr/share (i.e a level below the
> prefix).
>
>
> Diffs
> -----
>
> app/CMakeLists.txt 2e176e3c872bd066b731b907c53b6b3653901d38
> app/KHotKeysDBusInterfaceConfig.cmake.in b217a433a242613d7443b1b2c708095df1c6d7c3
>
> Diff: https://git.reviewboard.kde.org/r/125845/diff/
>
>
> Testing
> -------
>
> The affected dbus interface file gets installed in the desired location and the path in KHotKeysDBusInterfaceConfig.cmake correctly points to it.
>
>
> Thanks,
>
> Heiko Becker
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151028/f56df76b/attachment.html>
More information about the Plasma-devel
mailing list