Review Request 125843: Use KDE_INSTALL_DBUSINTERFACEDIR to install dbus interfaces
Alex Merry
alex.merry at kde.org
Wed Oct 28 20:18:34 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125843/#review87614
-----------------------------------------------------------
Ship it!
Ship It!
- Alex Merry
On Oct. 28, 2015, 5:31 p.m., Heiko Becker wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125843/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2015, 5:31 p.m.)
>
>
> Review request for Plasma and Martin Gräßlin.
>
>
> Repository: kwin
>
>
> Description
> -------
>
> ...and use PATH_VARS to make the config file work with absolute paths.
>
> Two reasons to do this:
> - DBUS_INTERFACES_INSTALL_DIR is marked deprecated
> - Not hard-coding the packackage prefix is helpful on a multiarch
> layout where the prefix is /usr/${host} but arch-independent files
> should still be installed to /usr/share (i.e a level below the
> prefix).
>
>
> Diffs
> -----
>
> CMakeLists.txt 44a423cb723121537a2c2adaa17c1d9f8875f9b8
> KWinDBusInterfaceConfig.cmake.in 762a2ed20221860c50f70a1e551eb74b3b1e0f3a
>
> Diff: https://git.reviewboard.kde.org/r/125843/diff/
>
>
> Testing
> -------
>
> The affected files are still installed in the desired place and the paths in KWinDBusInterfaceConfig.cmake are correct.
>
>
> Thanks,
>
> Heiko Becker
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151028/3d073463/attachment.html>
More information about the Plasma-devel
mailing list