Review Request 125837: [screenlocker] Remove libkworkspace dep

Bhushan Shah bhush94 at gmail.com
Wed Oct 28 16:41:17 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125837/
-----------------------------------------------------------

(Updated Oct. 28, 2015, 4:41 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, David Edmundson and Martin Gräßlin.


Changes
-------

Submitted with commit dcdb990e3841d406113ea73997cad67868ac0402 by Bhushan Shah to branch master.


Repository: plasma-workspace


Description
-------

>From the KDisplayManager code :

```
// This only tells KDM to not auto-re-login upon session crash
void                                                          
KDisplayManager::setLock(bool on)                             
{                                                             
    if (DMType == NewKDM || DMType == OldKDM)                 
        exec(on ? "lock\n" : "unlock\n");                     
}
```

Given we no longer have kdm in Plasma 5. This hardly makes sense.


Diffs
-----

  ksmserver/screenlocker/CMakeLists.txt 5ded06e 
  ksmserver/screenlocker/ksldapp.cpp ae4f701 

Diff: https://git.reviewboard.kde.org/r/125837/diff/


Testing
-------

builds and tests passes.


Thanks,

Bhushan Shah

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151028/bf2f7aa3/attachment.html>


More information about the Plasma-devel mailing list