Review Request 125841: toggle minimize api for plasma windowmanagement in kwayland

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125841/#review87598
-----------------------------------------------------------



src/client/plasmawindowmanagement.h (line 229)
<https://git.reviewboard.kde.org/r/125841/#comment60136>

    The grammar here needs to be fixed because it makes the semantics ambiguous. Is the request sent to the window or which agent arbitrates this?


- Eike Hein


On Oct. 28, 2015, 2:01 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125841/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2015, 2:01 p.m.)
> 
> 
> Review request for Plasma and Eike Hein.
> 
> 
> Repository: kwayland
> 
> 
> Description
> -------
> 
> add a method to toggle minimize and maximize windows from the plasma-window-management protocol.
> 
> 
> Diffs
> -----
> 
>   src/client/plasmawindowmanagement.h 707ca80 
>   src/client/plasmawindowmanagement.cpp dd72463 
>   src/client/plasmawindowmodel.h 02b88f4 
>   src/client/plasmawindowmodel.cpp 2cdfd6b 
> 
> Diff: https://git.reviewboard.kde.org/r/125841/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151028/441711f7/attachment.html>