Review Request 125743: Keep aspect ratio in default KSplash background

[Martin Klapetek]

> On Oct. 21, 2015, 11:05 p.m., David Edmundson wrote:
> > Makes sense for the default behaviours to match
> 
> Martin Klapetek wrote:
>     Match what? Do we have similar code elsewhere? Btw Hrvoje reported that this is less than ideal as it "letterboxes" the background, which I was a bit worried about.
>     
>     So, I'm thinking about Image.PreserveAspectCrop rather.
> 
> David Edmundson wrote:
>     match imagewallpaper default

Ah, but image wallpaper uses image package, so it has much more resolutions to choose from (the default anyway). This has a single one, so I think we should ship 16:10 ratio background and just center-crop it.


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125743/#review87228
-----------------------------------------------------------


On Oct. 21, 2015, 8:51 p.m., Martin Klapetek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125743/
> -----------------------------------------------------------
> 
> (Updated Oct. 21, 2015, 8:51 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> I'm just not sure if it's better to do Fit or Crop. I went with Fit as that simply fits the whole artwork, but let me know if you think differently.
> 
> Ideally this should use a wallpaper package for the background, but I don't know how to use it from QML (if possible at all).
> 
> Issues with Fit:
> * If the image is different aspect ratio than the screen, it would add black borders either above/below or left/right
> 
> Issues with Crop:
> * if the image has bigger resolution than the screen, it will get cropped to be the screen resolution, so eg. the distro ships 1920x1200 wallpaper and on 1024x768 the crop would be quite big (the image would still be centered so cropped on the sides)
> 
> 
> Diffs
> -----
> 
>   lookandfeel/contents/splash/Splash.qml fdeb1ea 
> 
> Diff: https://git.reviewboard.kde.org/r/125743/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Martin Klapetek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151028/c15910e4/attachment-0001.html>