Review Request 125838: [screenlocker] Turn kscreenlocker in to shared library from static

[Hrvoje Senjan]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125838/#review87575
-----------------------------------------------------------



ksmserver/screenlocker/CMakeLists.txt (line 41)
<https://git.reviewboard.kde.org/r/125838/#comment60127>

    if this will be shared lib, please extract private vs. public deps.



ksmserver/screenlocker/CMakeLists.txt (line 78)
<https://git.reviewboard.kde.org/r/125838/#comment60128>

    >To make screenlocker in wayland possible, kwin_wayland will need to link to libksld.
    
    but here you skip the symlink?


- Hrvoje Senjan


On Oct. 28, 2015, 12:07 p.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125838/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2015, 12:07 p.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> To make screenlocker in wayland possible, kwin_wayland will need to link to libksld.
> 
> (if packagers can look at this patch it would be nice)
> 
> 
> Diffs
> -----
> 
>   ksmserver/CMakeLists.txt a0c8852 
>   ksmserver/screenlocker/CMakeLists.txt 5ded06e 
>   ksmserver/screenlocker/autotests/CMakeLists.txt 7e7acdc 
>   ksmserver/screenlocker/ksldapp.h 9058824 
>   ksmserver/screenlocker/tests/CMakeLists.txt 7f0db74 
> 
> Diff: https://git.reviewboard.kde.org/r/125838/diff/
> 
> 
> Testing
> -------
> 
> builds/installs and tests pass
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151028/37c3123f/attachment.html>