Review Request 125837: [screenlocker] Remove libkworkspace dep

Martin Gräßlin mgraesslin at kde.org
Wed Oct 28 10:15:45 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125837/#review87567
-----------------------------------------------------------


+1 from my side.

- Martin Gräßlin


On Oct. 28, 2015, 11:13 a.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125837/
> -----------------------------------------------------------
> 
> (Updated Oct. 28, 2015, 11:13 a.m.)
> 
> 
> Review request for Plasma, David Edmundson and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> From the KDisplayManager code :
> 
> ```
> // This only tells KDM to not auto-re-login upon session crash
> void                                                          
> KDisplayManager::setLock(bool on)                             
> {                                                             
>     if (DMType == NewKDM || DMType == OldKDM)                 
>         exec(on ? "lock\n" : "unlock\n");                     
> }
> ```
> 
> Given we no longer have kdm in Plasma 5. This hardly makes sense.
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/CMakeLists.txt 5ded06e 
>   ksmserver/screenlocker/ksldapp.cpp ae4f701 
> 
> Diff: https://git.reviewboard.kde.org/r/125837/diff/
> 
> 
> Testing
> -------
> 
> builds and tests passes.
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151028/99426050/attachment.html>


More information about the Plasma-devel mailing list