Review Request 125821: [Kickerdash] Close when opening applet settings

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125821/#review87531
-----------------------------------------------------------

Ship it!


Makes sense. It used to open before the Dash before the recent focus changes.

- Eike Hein


On Oct. 26, 2015, 10:19 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125821/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2015, 10:19 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Given the window would open *behind* the dash, it makes sense to just close the dash when opening the applet's settings.
> 
> 
> Diffs
> -----
> 
>   applets/kicker/package/contents/ui/DashboardRepresentation.qml 17d2deb 
> 
> Diff: https://git.reviewboard.kde.org/r/125821/diff/
> 
> 
> Testing
> -------
> 
> Right clicked, "App dash settings", closed, settings dialog appeared.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151027/2c568337/attachment.html>