Review Request 125814: add kconf script to set gtk theme to breeze
David Edmundson
david at davidedmundson.co.uk
Tue Oct 27 11:00:14 UTC 2015
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125814/#review87505
-----------------------------------------------------------
kconf_update/main.cpp (line 144)
<https://git.reviewboard.kde.org/r/125814/#comment60085>
QStandardPaths::writableLocation
kconf_update/main.cpp (line 180)
<https://git.reviewboard.kde.org/r/125814/#comment60084>
the result of setGtk2 is lost
I assume we want some sort of
result |= setGtk3
- David Edmundson
On Oct. 27, 2015, 10:36 a.m., Jonathan Riddell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125814/
> -----------------------------------------------------------
>
> (Updated Oct. 27, 2015, 10:36 a.m.)
>
>
> Review request for Plasma and David Edmundson.
>
>
> Repository: breeze-gtk
>
>
> Description
> -------
>
> sets gtk theme to breeze if it's not set or it's using oxygen/orion which we've set before
>
> this is moving the code from breeze/misc and updating it for the new theme
>
>
> Diffs
> -----
>
> CMakeLists.txt 9d7b7a7
> kconf_update/CMakeLists.txt PRE-CREATION
> kconf_update/gtkbreeze5.5.upd PRE-CREATION
> kconf_update/main.cpp PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/125814/diff/
>
>
> Testing
> -------
>
> run the kconf_update script with no gtkrc files and with files set to orion
>
>
> Thanks,
>
> Jonathan Riddell
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151027/fb566f94/attachment-0001.html>
More information about the Plasma-devel
mailing list