Review Request 125814: add kconf script to set gtk theme to breeze

David Edmundson david at davidedmundson.co.uk
Tue Oct 27 10:57:14 UTC 2015



> On Oct. 26, 2015, 5:55 p.m., David Edmundson wrote:
> > kconf_update/main.cpp, line 171
> > <https://git.reviewboard.kde.org/r/125814/diff/1/?file=412868#file412868line171>
> >
> >     not needed
> 
> Jonathan Riddell wrote:
>     ok but then how do I turn on debugging?

by default QLoggingCategory does everything > Debug (i.e info, warn, critical, fatal)

so this turns it off to be the same as the default

You can specify a different default as an extra arg to Q_LOGGING_CATEGORY


- David


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125814/#review87450
-----------------------------------------------------------


On Oct. 27, 2015, 10:36 a.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125814/
> -----------------------------------------------------------
> 
> (Updated Oct. 27, 2015, 10:36 a.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: breeze-gtk
> 
> 
> Description
> -------
> 
> sets gtk theme to breeze if it's not set or it's using oxygen/orion which we've set before
> 
> this is moving the code from breeze/misc and updating it for the new theme
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 9d7b7a7 
>   kconf_update/CMakeLists.txt PRE-CREATION 
>   kconf_update/gtkbreeze5.5.upd PRE-CREATION 
>   kconf_update/main.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125814/diff/
> 
> 
> Testing
> -------
> 
> run the kconf_update script with no gtkrc files and with files set to orion
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151027/322f18c3/attachment.html>


More information about the Plasma-devel mailing list