Review Request 125810: Add some formfactor info to plasma-workspace applets

[Marco Martin]

> On Oct. 26, 2015, 9:12 p.m., Sebastian Kügler wrote:
> > applets/notifications/package/metadata.desktop, line 170
> > <https://git.reviewboard.kde.org/r/125810/diff/1/?file=412836#file412836line170>
> >
> >     We have a special notifications applet for handsets in plasma-mobile, so this should probably be more limited (exactly the opposite keys of plasma-mobile's notifications applet).

recently on the phone it switched to using the desktop applet as well, as was decided to move it in the top panel (since on the desktop wasn't possible to "peek", and being easy to remove it was quite a problem)
so unless they diverge again, it would exist only this one for now


> On Oct. 26, 2015, 9:12 p.m., Sebastian Kügler wrote:
> > applets/devicenotifier/package/metadata.desktop, line 172
> > <https://git.reviewboard.kde.org/r/125810/diff/1/?file=412832#file412832line172>
> >
> >     Could you share the reasoning for this choice?

mainly because doesn't make a lot of sense on the targeted device, perhaps on one with a microsd slot would make sense, so yeah, should probably be in


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125810/#review87465
-----------------------------------------------------------


On Oct. 26, 2015, 4:26 p.m., Marco Martin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125810/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2015, 4:26 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> added some formfactor keywords in the applets metadata. once the explorer model filters them accordingly, it should remove a bit of applets problematic on the phone for one reason or another
> 
> 
> Diffs
> -----
> 
>   applets/activitybar/metadata.desktop d6cf69c 
>   applets/analog-clock/metadata.desktop 4246c6e 
>   applets/batterymonitor/package/metadata.desktop a4ee702 
>   applets/calendar/metadata.desktop 5891264 
>   applets/clipboard/metadata.desktop 1d699d2 
>   applets/devicenotifier/package/metadata.desktop d71ce72 
>   applets/digital-clock/package/metadata.desktop b881453 
>   applets/lock_logout/metadata.desktop f53f541 
>   applets/mediacontroller/metadata.desktop d4ea37a 
>   applets/notifications/package/metadata.desktop 2beb20d 
>   applets/systemmonitor/cpu/metadata.desktop 76cd74d 
>   applets/systemmonitor/diskactivity/metadata.desktop 2a1ceaa 
>   applets/systemmonitor/diskusage/metadata.desktop 08344a8 
>   applets/systemmonitor/net/metadata.desktop 6671fba 
>   applets/systemtray/package/metadata.desktop 0ce0512 
> 
> Diff: https://git.reviewboard.kde.org/r/125810/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marco Martin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151027/713388ab/attachment-0001.html>