Review Request 125618: Fixes to KameraConfigDialog

[Christian Butcher]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125618/
-----------------------------------------------------------

(Updated Oct. 27, 2015, 8:45 a.m.)


Review request for KDE Graphics, Plasma and Marcus Meissner.


Changes
-------

Check dynamic_cast pointers before using them


Repository: kamera


Description
-------

Fixes to the KameraConfigDialog dialogue problems, as seen in the screenshots attached to [this previous review](https://git.reviewboard.kde.org/r/125433/). 

Adds a QScrollArea (with no frame) to allow resizing more easily.

Labels are on the left side of the GridLayouts now, with their controls to the right (LineEdit, CheckBox, Slider).
The labels are almost the same in each of the three cases, but unsure that making just one Label, then changing based on an if() is an improvement.


Diffs (updated)
-----

  kcontrol/kameraconfigdialog.cpp f8cdd43b9623ab26b868399ecf3e184c03b41d57 

Diff: https://git.reviewboard.kde.org/r/125618/diff/


Testing
-------

Tested with Nikon 1 V2, which seems to have a significant number of available fields, and of varied types. Expect that not all `GP_WIDGET_{x,y,z}` are covered.
Tried to test with phone but uses MTP - Plasma and Dolphin allow me to open it nicely, and Kamera KCM shows the phone, but won't allow any actions on it. 
Unsure if this means that the KCM should discard MTP phones with which it can't interface.


Thanks,

Christian Butcher

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151027/6d4db7b1/attachment.html>