Review Request 125775: System Tray: Add ScrollArea to hidden items view

[Sebastian Kügler]

> On Oct. 26, 2015, 10:13 a.m., Sebastian Kügler wrote:
> > applets/systemtray/package/contents/ui/ExpandedRepresentation.qml, line 81
> > <https://git.reviewboard.kde.org/r/125775/diff/1/?file=412455#file412455line81>
> >
> >     Why are you removing this? It seems unrelated to the rest of this patch.
> 
> David Rosca wrote:
>     Because I couldn't find any use of this and thus I don't know if it should be in ListView or in ScrollArea (that now has "hiddenView" id). I guess it was used from C++ to get handle of the ListView, but isn't used anymore?
> 
> Sebastian Kügler wrote:
>     Alright, I think it can be removed, but please make sure by grepping for "hiddenView" through the source. If it's not used, feel free to drop this issue.
> 
> David Rosca wrote:
>     I actually did just that before removing it :) There is no use of it in plasma-workspace.

Okay, one step ahead of me. Great. :-)


- Sebastian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125775/#review87414
-----------------------------------------------------------


On Oct. 24, 2015, 6:21 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125775/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2015, 6:21 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 341165
>     https://bugs.kde.org/show_bug.cgi?id=341165
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Show vertical scrollbar when hidden items doesn't fit in popup.
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/package/contents/ui/ExpandedRepresentation.qml 728452f 
> 
> Diff: https://git.reviewboard.kde.org/r/125775/diff/
> 
> 
> Testing
> -------
> 
> Works, although mouse scrolling works only on the scrollbar.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151026/54274b73/attachment-0001.html>