Review Request 124675: Fix Bug 311991 - Taskbar buttons for minimized apps should not use disabled state

[Thomas Pfeiffer]

> On Oct. 25, 2015, 10:05 p.m., Thomas Pfeiffer wrote:
> > As always: If you want design or usability input, please provide a screenshot. We cannot read the code. Thanks.
> 
> Eike Hein wrote:
>     Thomas, all this does is not grey out the text in Task Manager button labels when a window is minimized. See also the long discussion in the referenced bug ticket.

Thanks, I just wanted to make sure what it specifically does.
In that case, I am against the patch as it is. There should be some way of distinguishing minimized from non-minimized tasks.
I agree with the problem, but I do not agree with the solution.

Would it be possible to instead of hardcoded greying-out (which I also agree is not the right representation, because greying out is reserved for disabled controls) allow the Plasma theme to define the visual representation?
In the Breeze theme, it would make sense (as suggested in the bug thread) to use a different color for the highlight bar instead of changing the representation of the task. Other themes might choose differen representations, or just don't distinguish them at all.


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124675/#review87384
-----------------------------------------------------------


On Oct. 23, 2015, 11:16 a.m., Gregor Mi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/124675/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 11:16 a.m.)
> 
> 
> Review request for Plasma, KDE Usability and Jens Reuterberg.
> 
> 
> Bugs: 311991
>     https://bugs.kde.org/show_bug.cgi?id=311991
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> This fixes Bug 311991. Though I am not sure if there are side effects which I am not aware of.
> 
> 
> Diffs
> -----
> 
>   applets/taskmanager/package/contents/ui/Task.qml f655801ab1f7b1a9a915f35149c858f0ede22a29 
> 
> Diff: https://git.reviewboard.kde.org/r/124675/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Gregor Mi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151026/938e8c9f/attachment-0001.html>