Review Request 125451: RFC: Drop KScreen dependency from PlasmaShell

Aleix Pol Gonzalez aleixpol at kde.org
Mon Oct 26 17:39:59 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125451/
-----------------------------------------------------------

(Updated Oct. 26, 2015, 6:39 p.m.)


Review request for Plasma.


Changes
-------

Adopt some changes, including the problem david spotted.


Repository: plasma-workspace


Description
-------

Now that everything's in place in Qt, we can do that.

It basically removes all the translation layer between KScreen and QScreen.

NOTE: This can't be merged until Qt 5.6 is a dependency.


Diffs (updated)
-----

  CMakeLists.txt 50091ea 
  shell/CMakeLists.txt e17e4a3 
  shell/desktopview.h 867cfdc 
  shell/desktopview.cpp 42a1f08 
  shell/panelview.h 9f8d4ce 
  shell/panelview.cpp 3317b52 
  shell/shellcorona.h b04b102 
  shell/shellcorona.cpp 56570b4 

Diff: https://git.reviewboard.kde.org/r/125451/diff/


Testing
-------

Hands-on testing, it's been working quite fluid and I couldn't find a crash. (There could be crashes, I just didn't find them :D)


Thanks,

Aleix Pol Gonzalez

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151026/9337f0cf/attachment.html>


More information about the Plasma-devel mailing list