Review Request 125811: detect gtk engine

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125811/#review87436
-----------------------------------------------------------



CMakeLists.txt (line 14)
<https://git.reviewboard.kde.org/r/125811/#comment60017>

    remove



cmake/FindGTKEngine.cmake (line 9)
<https://git.reviewboard.kde.org/r/125811/#comment60016>

    what if the GTK version isn't 2.10?



cmake/FindGTKEngine.cmake~ (line 1)
<https://git.reviewboard.kde.org/r/125811/#comment60014>

    git rm this file



cmake/GTKEngineConfig.cmake (line 3)
<https://git.reviewboard.kde.org/r/125811/#comment60015>

    that's not distro agnostic
    
    I think there's a cmake var for libpath


- David Edmundson


On Oct. 26, 2015, 4:43 p.m., Jonathan Riddell wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125811/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2015, 4:43 p.m.)
> 
> 
> Review request for Plasma and David Edmundson.
> 
> 
> Repository: breeze-gtk
> 
> 
> Description
> -------
> 
> first attempt at detecting gtk 2 pixmap engine as runtime dependency
> 
> but it doesn't work if you set cmake path to different from gtk engine
> 
> and I don't know if it works on distros that use /usr/lib64/ rather than /usr/lib/x86_86-linux-gnu
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt b977da8 
>   cmake/FindGTKEngine.cmake PRE-CREATION 
>   cmake/FindGTKEngine.cmake~ PRE-CREATION 
>   cmake/GTKEngineConfig.cmake PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125811/diff/
> 
> 
> Testing
> -------
> 
> works for me unless I install outwith /usr/
> 
> 
> Thanks,
> 
> Jonathan Riddell
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151026/0f0f5054/attachment.html>