Review Request 125775: System Tray: Add ScrollArea to hidden items view

[Marco Martin]

> On Oct. 26, 2015, 9:12 a.m., Marco Martin wrote:
> > applets/systemtray/package/contents/ui/ExpandedRepresentation.qml, line 129
> > <https://git.reviewboard.kde.org/r/125775/diff/1/?file=412455#file412455line129>
> >
> >     this shouldn't be necessary, as hiddenView should still be just hidden when root.expandedTask != null, and when contentHeight < height shouldn't be interactive and scrollbar should be hidden
> 
> David Rosca wrote:
>     You mean the whole Qt.binding is not necessary, or just the !root.expandedTask test? The !root.expandedTask is there to disable interactivity when only the column with icons on the left is visible and the plasmoid contents is on the right in popup (eg. when you open popup with clicking on Show hidden icons arrow and then select some item).

The whole Component.onCompleted: handler can be removed, yes


- Marco


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125775/#review87410
-----------------------------------------------------------


On Oct. 24, 2015, 6:21 p.m., David Rosca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125775/
> -----------------------------------------------------------
> 
> (Updated Oct. 24, 2015, 6:21 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 341165
>     https://bugs.kde.org/show_bug.cgi?id=341165
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Show vertical scrollbar when hidden items doesn't fit in popup.
> 
> 
> Diffs
> -----
> 
>   applets/systemtray/package/contents/ui/ExpandedRepresentation.qml 728452f 
> 
> Diff: https://git.reviewboard.kde.org/r/125775/diff/
> 
> 
> Testing
> -------
> 
> Works, although mouse scrolling works only on the scrollbar.
> 
> 
> Thanks,
> 
> David Rosca
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151026/c7755970/attachment.html>