Review Request 125802: Split generic parts from X11Locker into AbstractLocker

[Martin Gräßlin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125802/#review87402
-----------------------------------------------------------



ksmserver/screenlocker/abstractlocker.h (line 66)
<https://git.reviewboard.kde.org/r/125802/#comment60000>

    stayOnTop is public in the Abstract class, but private in the implementing class. Is it supposed to be public? If not I suggest to move to protected.



ksmserver/screenlocker/x11locker.h (lines 47 - 48)
<https://git.reviewboard.kde.org/r/125802/#comment59999>

    add "override" to the overriden methods


- Martin Gräßlin


On Oct. 26, 2015, 8:32 a.m., Bhushan Shah wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125802/
> -----------------------------------------------------------
> 
> (Updated Oct. 26, 2015, 8:32 a.m.)
> 
> 
> Review request for Plasma and Martin Gräßlin.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Advantage of this split is some parts such as showLockWindow and hideLockWindow needs platform specific code. So instead of doing complex if/else branching we can have seperate X11Locker and WaylandLocker.
> 
> 
> Diffs
> -----
> 
>   ksmserver/screenlocker/abstractlocker.cpp PRE-CREATION 
>   ksmserver/screenlocker/CMakeLists.txt 24a89f6 
>   ksmserver/screenlocker/abstractlocker.h PRE-CREATION 
>   ksmserver/screenlocker/autotests/CMakeLists.txt ab901ca 
>   ksmserver/screenlocker/autotests/lockwindowtest.cpp 444c44f 
>   ksmserver/screenlocker/autotests/x11lockertest.cpp PRE-CREATION 
>   ksmserver/screenlocker/ksldapp.h b281ab6 
>   ksmserver/screenlocker/ksldapp.cpp 68ebfc2 
>   ksmserver/screenlocker/lockwindow.h c4013be 
>   ksmserver/screenlocker/lockwindow.cpp e46733e 
>   ksmserver/screenlocker/x11locker.h PRE-CREATION 
>   ksmserver/screenlocker/x11locker.cpp PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/125802/diff/
> 
> 
> Testing
> -------
> 
> builds, installs, autotests and kscreenlocker_test passes, normal lockscreen also works.
> 
> 
> Thanks,
> 
> Bhushan Shah
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151026/7b178c87/attachment.html>