Review Request 125793: [Task Manager] Add proper close button to tooltip

[Andrew Lake]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125793/#review87395
-----------------------------------------------------------


Proper close button is welcome. Generally looks good to me, though I do think the close button works better with the consistency of the normal background rather than the randomness of the thumbnail as a background. Other than that, thumbs up from me!

- Andrew Lake


On Oct. 25, 2015, 9:42 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125793/
> -----------------------------------------------------------
> 
> (Updated Oct. 25, 2015, 9:42 p.m.)
> 
> 
> Review request for Plasma, KDE Usability and Andrew Lake.
> 
> 
> Bugs: 350705
>     https://bugs.kde.org/show_bug.cgi?id=350705
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> I just found this patch I made a while ago. This turns the handmade close button into a regular ToolButton (which is only shown when hovering) with a proper size. Also, the button is always in the top right corner of the *thumbnail* rather than the dialog
> 
> 
> Diffs
> -----
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/125793/diff/
> 
> 
> Testing
> -------
> 
> Works.
> 
> 
> File Attachments
> ----------------
> 
> New close button
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/10/25/0fea55c5-5a9b-4321-bec5-34ec3bacf239__closebuttonproper.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151026/abde4ad0/attachment.html>