Review Request 125793: [Task Manager] Add proper close button to tooltip

[Kai Uwe Broulik]

> On Okt. 25, 2015, 9:12 nachm., Thomas Pfeiffer wrote:
> > Can you please add Andrew for design review? 
> > From a usability perspective, it would be better if the button was outside the actual thumbnail, to be sure that it cannot be mistaken as part of the thumbnail.

the button only appears on hovering, so it should be obvious it's not part of the thumbnail


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125793/#review87381
-----------------------------------------------------------


On Okt. 25, 2015, 5:06 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125793/
> -----------------------------------------------------------
> 
> (Updated Okt. 25, 2015, 5:06 nachm.)
> 
> 
> Review request for Plasma and KDE Usability.
> 
> 
> Bugs: 350705
>     https://bugs.kde.org/show_bug.cgi?id=350705
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> I just found this patch I made a while ago. This turns the handmade close button into a regular ToolButton (which is only shown when hovering) with a proper size. Also, the button is always in the top right corner of the *thumbnail* rather than the dialog
> 
> 
> Diffs
> -----
> 
>   applets/taskmanager/package/contents/ui/ToolTipDelegate.qml f7084c7 
> 
> Diff: https://git.reviewboard.kde.org/r/125793/diff/
> 
> 
> Testing
> -------
> 
> Works.
> 
> 
> File Attachments
> ----------------
> 
> New close button
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/10/25/0fea55c5-5a9b-4321-bec5-34ec3bacf239__closebuttonproper.png
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151025/84ad835c/attachment-0001.html>