Review Request 125770: Emit correct signal for notifications expiring

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125770/#review87336
-----------------------------------------------------------


+1


dataengines/notifications/notificationaction.cpp (line 58)
<https://git.reviewboard.kde.org/r/125770/#comment59975>

    Update comment



dataengines/notifications/notificationsengine.cpp (line 374)
<https://git.reviewboard.kde.org/r/125770/#comment59976>

    iirc you can use QStringLiteral with .args()



dataengines/notifications/notificationsengine.cpp (lines 375 - 376)
<https://git.reviewboard.kde.org/r/125770/#comment59977>

    I would turn the comment around "Only if we have that notification ..."


- Kai Uwe Broulik


On Okt. 24, 2015, 12:40 nachm., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125770/
> -----------------------------------------------------------
> 
> (Updated Okt. 24, 2015, 12:40 nachm.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-workspace
> 
> 
> Description
> -------
> 
> Expired notifications should emit a different reason in
> NotificationClosed than manually closed notifications
> 
> See https://people.gnome.org/~mccann/docs/notification-spec/notification-spec-1.1.html#signal-notification-closed
> 
> BUG: 354293
> 
> 
> Diffs
> -----
> 
>   applets/notifications/package/contents/ui/NotificationPopup.qml 5fd06bb4ee437e673ef9cc09907764b40cfa5a74 
>   applets/notifications/package/contents/ui/Notifications.qml 13be7d49a14ebbe5399a7f0bf333862f545671a2 
>   dataengines/notifications/notificationaction.cpp 5302f7808fd43c924a3f7b1fd7cfc0acba45c500 
>   dataengines/notifications/notifications.operations 046776ec1af981d7fb23db9ddb9bd9d34ec55300 
>   dataengines/notifications/notificationsengine.h 52590950ad1c85f427502b598e0b21d8a65e587e 
>   dataengines/notifications/notificationsengine.cpp 42e56d8ab27b3a012381cbd0ce39c6322d09e152 
> 
> Diff: https://git.reviewboard.kde.org/r/125770/diff/
> 
> 
> Testing
> -------
> 
> Ran dbus-monitor & notify-send
> 
> let one notification expire
> clicked close on another
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151024/6d993c62/attachment.html>