Review Request 125764: Fix kinfocenter crash when run with --version

David Edmundson david at davidedmundson.co.uk
Fri Oct 23 13:09:00 UTC 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125764/#review87307
-----------------------------------------------------------

Ship it!


Do you have push access?

- David Edmundson


On Oct. 23, 2015, 1:06 p.m., Antonio Larrosa Jimenez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125764/
> -----------------------------------------------------------
> 
> (Updated Oct. 23, 2015, 1:06 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kinfocenter
> 
> 
> Description
> -------
> 
> Fix the order in which kinfocenter is initialized to first do all
> commandline parsing and only then create windows. In other case
> running "kinfocenter --version" crashes when unloading dynamic libraries
> that shouldn't have been loaded at all.
> 
> 
> Diffs
> -----
> 
>   main.cpp 42f4c6a527e0ba6a76529d1f25bfe1e5d9a485bf 
> 
> Diff: https://git.reviewboard.kde.org/r/125764/diff/
> 
> 
> Testing
> -------
> 
> Noticed that "kinfocenter --version" crashed.
> I made this patch, built it and tested it doesn't crash anymore.
> 
> 
> Thanks,
> 
> Antonio Larrosa Jimenez
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151023/16b771eb/attachment.html>


More information about the Plasma-devel mailing list