Review Request 125745: Energy module: Limit org.freedesktop.UPower.Wakeups.GetData calls to one per second

[David Rosca]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125745/
-----------------------------------------------------------

(Updated Oct. 22, 2015, 2:41 p.m.)


Status
------

This change has been marked as submitted.


Review request for KInfoCenter and Plasma.


Changes
-------

Submitted with commit 5e8760df9ce119df92a386f42af3555dd43ec2cf by David Rosca to branch Plasma/5.4.


Repository: kinfocenter


Description
-------

It is possible that DataChanged is emitted very quickly, up to the point that upower won't be able to respond, resulting in errors due to maximum number of pending replies.
One update per second should be enough.


Diffs
-----

  Modules/energy/wakeupmodel.h ce0809b 
  Modules/energy/wakeupmodel.cpp 372ae2d 

Diff: https://git.reviewboard.kde.org/r/125745/diff/


Testing
-------

On Debian with upower (0.99.3-1+b2), after opening energy module upower would quickly start to use 100% cpu. This patch fixes it and makes the history graph appear, but there are still some other issues...


Thanks,

David Rosca

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151022/a9b79af1/attachment.html>