Review Request 125555: Port KAuth return code error checking in fontinst

[Martin Gräßlin]

> On Oct. 19, 2015, 12:40 p.m., Martin Gräßlin wrote:
> > kcms/kfontinst/dbus/FontInst.cpp, line 957
> > <https://git.reviewboard.kde.org/r/125555/diff/1/?file=410313#file410313line957>
> >
> >     that's an async call, isn't it? So somehow I doubt it will work that way.
> 
> David Edmundson wrote:
>     no, this is KJob::exec() which fires up a new event loop waiting for j to finish.
>     (and we can block here as we're not in a GUI program)
> 
> Martin Gräßlin wrote:
>     urgh ;-) I had huge problem with that once in KAuth in powerdevil with it blocking till the end of time. Are you sure you want to do it that way?
> 
> David Edmundson wrote:
>     I had a look.
>     
>     With the architecture of this, it'd be a huge change, that realistically I'm not going to do.
>     
>     It wouldn't directly affect anything anyway. We're displaying a dialog with a progress bar. If the job takes forever, the dialog in the main app is still stuck there forever. The root cause of that job taking forever needs fixing.
>     
>     This fixes at least one bug, fixing the rest can come in future patches.

Thanks for checking!


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125555/#review87060
-----------------------------------------------------------


On Oct. 8, 2015, 3:38 p.m., David Edmundson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125555/
> -----------------------------------------------------------
> 
> (Updated Oct. 8, 2015, 3:38 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: plasma-desktop
> 
> 
> Description
> -------
> 
> Someone whilst porting had simply commented it out
> This causes the install dialog to freeze if there's a problem.
> 
> CCBUG: 344473
> CCBUG: 300951
> CCBUG: 345234
> 
> 
> Diffs
> -----
> 
>   kcms/kfontinst/dbus/FontInst.cpp 42413c1a05717f416681ef32317b8914c2ba35ec 
> 
> Diff: https://git.reviewboard.kde.org/r/125555/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> David Edmundson
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151022/0a5babab/attachment-0001.html>