Review Request 125416: BugFix for "Bug 328807 - Removing sensor from graph causes KSysGuard crash" (affected SensorType: DancingBars)

[Christoph Feck]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125416/#review87231
-----------------------------------------------------------


Raphael, does the crash still happen with Plasma 5.4.2? There is a comment at bug 328807 mentioning a related bug 260869 about modality, which got fixed for Plasma 5.4.2.

- Christoph Feck


On Oct. 9, 2015, 3:43 p.m., Raphael Kugelmann wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125416/
> -----------------------------------------------------------
> 
> (Updated Oct. 9, 2015, 3:43 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Bugs: 328807
>     https://bugs.kde.org/show_bug.cgi?id=328807
> 
> 
> Repository: ksysguard
> 
> 
> Description
> -------
> 
> BugFix for "Bug 328807 - Removing sensor from graph causes KSysGuard crash" (affected SensorType: DancingBars)
> 
> https://bugs.kde.org/show_bug.cgi?id=328807
> 
> Two issues fixed:
> - crash during removing a bar Sensor
> - wrong Sensors is removed
> - labels are not set as expected after removing a bar
> 
> 
> Diffs
> -----
> 
>   gui/SensorDisplayLib/BarGraph.cpp ecd6674ea4f66c3c061feb31c6a68e2e7abed885 
>   gui/SensorDisplayLib/DancingBars.cpp 13c8a45f4f4ca9dd16f62cdf6295bcd6643d2a12 
>   gui/SensorDisplayLib/DancingBarsSettings.h 27df0666db53621ecddb2e4763b26509103f7381 
>   gui/SensorDisplayLib/DancingBarsSettings.cpp 6eb9c21b1670b028570e3826620b98e07eac266d 
> 
> Diff: https://git.reviewboard.kde.org/r/125416/diff/
> 
> 
> Testing
> -------
> 
> Tested
> - no crash anymore
> - the remaining sensors are the one as expected
> 
> 
> Thanks,
> 
> Raphael Kugelmann
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151021/b135f5ad/attachment.html>