Review Request 125719: make pre-specified view size precede initial object size in QuickViewSharedEngine

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125719/#review87229
-----------------------------------------------------------

Ship it!


Ship It!

- David Edmundson


On Oct. 20, 2015, 4:14 p.m., Takahiro Hashimoto wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125719/
> -----------------------------------------------------------
> 
> (Updated Oct. 20, 2015, 4:14 p.m.)
> 
> 
> Review request for Plasma.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Now QuickViewSharedEngine view size is initialized with its rootObject size in QuickViewSharedEnginePrivate::executionFinished(). 
> 
> In the case of setting its size before completing QuickViewSharedEnginePrivate::executionFinished(), it is forcely overwrote with rootObject size unexpectedly.
> 
> This problem happens when running ksplashqml on higher or lower resolution screen than breeze background image size(1920x1080) (see attached screenshot executing "ksplashqml --test" at 3200x1800 screen)
> 
> I think it would be  better that the view size which is specified by manual precede default size initialization process.  Adjusting view and object size can be done by syncResizeMode() in QuickViewSharedEnginePrivate::executionFinished().
> 
> This patch make the view size adjust to its rootObject size when view size isEmpty().
> 
> AFAIK, QuickViewSharedEngine is now used by screenlocker greeter and ksplashqml. I cannot imagine this change affect another use cases. Please let me have any advice:)
> 
> 
> Diffs
> -----
> 
>   src/quickaddons/quickviewsharedengine.cpp b57d7dc 
> 
> Diff: https://git.reviewboard.kde.org/r/125719/diff/
> 
> 
> Testing
> -------
> 
> apply this patch and confirmed ksplashqml content was adjusted to screen size correctly.
> screenlocker remain working fine to me.
> 
> 
> File Attachments
> ----------------
> 
> ksplash_incorrect_resolution.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2015/10/20/3775b064-1463-478b-888a-f4d173ec696c__ksplash_incorrect_resolution.png
> 
> 
> Thanks,
> 
> Takahiro Hashimoto
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151021/87ad10cb/attachment-0001.html>