Review Request 125655: Xembed SNI Proxy

[David Edmundson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125655/
-----------------------------------------------------------

(Updated Oct. 21, 2015, 9 p.m.)


Review request for Plasma.


Changes
-------

Implement some of the things.
The two comments that I haven't clicked "fixed" on still remain.


Repository: plasma-workspace


Description
-------

The goal of this project is to make xembed system trays available in Plasma.

This is to allow legacy apps (xchat, pidgin, tuxguitar) etc. system trays[1] available in Plasma which only supports StatusNotifierItem [2].

Ideally we also want this to work in an xwayland session, making X system tray icons available even when plasmashell only has a wayland connection.

How it works (in theory)

* We register a window as a system tray container
* We render embeded windows composited offscreen
* We render contents into an image and send this over DBus via the SNI protocol
* XDamage events trigger a repaint
* Activate and context menu events are replyed via X send event into the embedded container as left and right clicks


Code is a mix of hacks and bodges bashing client apps into place, and I happily acknowledge it looks pretty bad. Unfotunately most of it seems to be needed, but I'd love to be proved wrong on most of it.

---

CMakeLists changes are obviously currently wrong, I can strip half of find_packages and I need an add_subdirectory in the root file, but it's easier for me to sync with the separate repo mirror this way till we're close to merging. I expect this to take quite some revisions.


Diffs (updated)
-----

  ksplash/ksplashqml/CMakeLists.txt ce55b8e6ca7e8556935325fdee86d396cdce77fb 
  ksplash/ksplashqml/splashapp.cpp 570c65c3e4b71595977162b6ec81f2309552839e 
  ksplash/ksplashqml/splashwindow.h 2afda0b3523ee0a3218f711dadf391e2128ecf8b 
  ksplash/ksplashqml/splashwindow.cpp 3e00ebac617fe49d7d25c08c86ec1f8975f957e1 
  shell/dbus/org.kde.PlasmaShell.xml cf2d0bbfcdb5720bf19d42403ee8c7fd542adecd 
  shell/shellcorona.h 0e6fe041787b2f75d791b38661b63614e27d33bf 
  shell/shellcorona.cpp 37d05347d67b7178db4d29a1ac368aacaacf0c0a 
  xembedsniproxy/CMakeLists.txt PRE-CREATION 
  xembedsniproxy/Readme.md PRE-CREATION 
  xembedsniproxy/debug.h PRE-CREATION 
  xembedsniproxy/fdoselectionmanager.h PRE-CREATION 
  xembedsniproxy/fdoselectionmanager.cpp PRE-CREATION 
  xembedsniproxy/main.cpp PRE-CREATION 
  xembedsniproxy/org.kde.StatusNotifierItem.xml PRE-CREATION 
  xembedsniproxy/org.kde.StatusNotifierWatcher.xml PRE-CREATION 
  xembedsniproxy/snidbus.h PRE-CREATION 
  xembedsniproxy/snidbus.cpp PRE-CREATION 
  xembedsniproxy/sniproxy.h PRE-CREATION 
  xembedsniproxy/sniproxy.cpp PRE-CREATION 
  xembedsniproxy/xcbutils.h PRE-CREATION 
  xembedsniproxy/xembedsniproxy.desktop PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/125655/diff/


Testing
-------


Thanks,

David Edmundson

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20151021/3836d331/attachment-0001.html>